AOP does not work :(

[Savagearts]

Hi guys:
I'm new to AOP and i try it with spring's AOP framework. But it does not work. Here are some code following:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE beans PUBLIC "-//SPRING//DTD BEAN//EN" "http://www.springframework.org/dtd/spring-beans.dtd">
<beans>

<bean id="autoProxyCreator" class="org.springframework.aop.framework.autoproxy.Defaul tAdvisorAutoProxyCreator">
</bean>

<bean id="beforeAdvice" class="com.savagearts.study.aop.spring.HelloWorldBeforeAd vise"/>

<bean id="helloworld" class="com.savagearts.study.aop.spring.HelloWorld">
<property name="greeting">
<value>hello world</value>
</property>
</bean>

<bean id="pointcut"
class="org.springframework.aop.support.RegexpMethodPointc ut">
<property name="patterns">
<list>
<value>.*get*</value>
</list>
</property>
</bean>

<bean id="advisor"
class="org.springframework.aop.support.DefaultPointcutAdv isor"
singleton="false">
<property name="pointcut">
<ref local="pointcut"/>
</property>
<property name="advice">
<ref local="beforeAdvice"/>
</property>
</bean>

</beans>



public class HelloWorld {
private String greeting;

public String getGreeting(){
return this.greeting;
}

public void setGreeting(String greeting) {
this.greeting = greeting;
}

public static void main(String[] args)throws Exception{
InputStream in = Thread.currentThread().getContextClassLoader().get ResourceAsStream("applicationContext.xml");
ApplicationContext factory = new ClassPathXmlApplicationContext("applicationContext.xml");
HelloWorld helloWorld=(HelloWorld)factory.getBean("helloworld");
System.out.print(helloWorld.getGreeting());
}
}


public class HelloWorldBeforeAdvise implements MethodBeforeAdvice{
private int count;

public void before(Method method, Object[] objects, Object o) throws Throwable {
count++;
System.out.print("executing method "+count +" times");
}
}[/code]

[Savagearts]

Can anybody give me some suggestion?

[Rod Johnson]

This config and code looks OK. When you say it doesn't work, I assume that you don't get your advice firing, rather than that there's any error?

So we'll have to try to eliminate possible causes. Please start by making your advice match everything by commenting out the Pointcut reference in the "advisor" bean definition, using the DefaultPointcutAdvisor default (Pointcut.TRUE), to see whether the pointcut is the problem.

[Savagearts]

Thanks, Mr Johnson. I've got your advice and i'll try it.

[robh]

There is an error in your regular expression - you need to use .*get.* not .*get* - notice the additional . before the last *.

Rob

[Savagearts]

I've fixed this problem. Anyway,Thanks .It's so kind of you spring guys.

[dima767]

BTW,

the org.springframework.aop.support.RegexpMethodPointc ut is deprecated, so I would suggest you switch to JdkRegexpMethodPointcut if you have JDK1.4 or higer or Perl5RegexpMethodPointcut if you have pre-1.4 JDK. Note that Perl5RegexpMethodPointcut would require a dependency on Jakarta ORO regular expression library.

[julius_ferns]

>>I've fixed this problem. Anyway,Thanks .It's so kind of you spring guys.

can u tell us how you got it fixed?What was the change you did?

[robh]

See my earlier post about the invalid regular expression pattern - that's the fix.

Rob

[julius_ferns]

for dynamic pointcut but works for static pointcuts



<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE beans PUBLIC "-//SPRING//DTD BEAN//EN" "http://www.springframework.org/dtd/spring-beans.dtd">
<beans >

<!--CONFIG-->
<bean id="businesslogicbean" class="org.springframework.aop.framework.ProxyFactoryBean">
<property name="proxyInterfaces">
<value>IBusinessLogic</value>
</property>

<property name="target">
<ref local="beanTarget"/>
</property>
<property name="interceptorNames">
<list>
<value>theAroundAdvisor</value>
</list>
</property>
</bean>

<!--CLASS-->
<bean id="beanTarget" class="BusinessLogic"/>

<!--ADVISOR-->
<!--Note: An advisor assembles pointcuts and advice-->
<!-- <bean id="theAroundAdvisor" class="org.springframework.aop.support.RegexpMethodPointc utAdvisor">
<property name="advice">
<ref local="theAroundAdvice"/>
</property>
<property name="pattern">
<value>.*</value>
</property>
</bean> -->

<bean id="mypointcut" class="org.springframework.aop.support.ControlFlowPointcu t">
<constructor-arg index="0" >
<value>AroundAdvice</value>
</constructor-arg>
</bean>

<bean id="theAroundAdvisor" class="org.springframework.aop.support.DefaultPointcutAdv isor">
<property name="pointcut">
<ref local="mypointcut"/>
</property>
<property name="advice">
<ref local="theAroundAdvice"/>
</property>
</bean>

<bean id="theAroundAdvice" class="AroundAdvice" />
</beans>